Details

      Description

      Blazegraph is using a very old version of Jetty - 9.2.3.v20140905 - which has bugs and lacks support for modern HTTPS protocols.

        Activity

        Hide
        stasmalyshev stasmalyshev added a comment -
        Show
        stasmalyshev stasmalyshev added a comment - Pull request: https://github.com/blazegraph/database/pull/124
        Show
        beebs Brad Bebee added a comment - https://github.com/blazegraph/bigdata/pull/522
        Hide
        beebs Brad Bebee added a comment -

        stasmalyshev The following tests failed. I haven't looked at them all, but you can run them individually such as:

        mvn -DtestClass=com.bigdata.rdf.sail.webapp.TestNanoSparqlServerWithProxyIndexManager -Dtest=com.bigdata.rdf.sail.webapp.ExampleProtocolTest#test101 test
        

        Based on this one, it appears that Jetty 9.4 adds the utf-8 return type (see below). It's quite possible at all of these failures are a similar cause.

        com.bigdata.rdf.sail.webapp.ExampleProtocolTest.test101(com.bigdata.rdf.sail.webapp.ExampleProtocolTest)
          Run 1: ExampleProtocolTest.test101:46 expected:<...n/sparql-results+xml[]> but was:<...n/sparql-results+xml[;charset=utf-8]>
          Run 2: ExampleProtocolTest.test101:46 expected:<...n/sparql-results+xml[]> but was:<...n/sparql-results+xml[;charset=utf-8]>
          Run 3: ExampleProtocolTest.test101:46 expected:<...n/sparql-results+xml[]> but was:<...n/sparql-results+xml[;charset=utf-8]>
        
        com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testTupleQueryDataset
        com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testTupleQueryIncludeInferred
        com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testTupleQueryBindings
        com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testTupleQueryBaseURI
        com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testExport
        com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testGetStatements
        com.bigdata.rdf.sail.webapp.ExampleProtocolTest.test101
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectGetJSON
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testAskGetXML
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectGetXML
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectPostEncodeJSON
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectPostEncodeXML
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testAskPostEncodeXML
        com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testSelectPostXML
        com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testAskPostXML
        com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testSelectPostJSON
        com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testAskPostJSON
        com.bigdata.rdf.sail.webapp.TestAskJsonTrac704.testAskGetJSON
        com.bigdata.rdf.sail.webapp.TestAskJsonTrac704.testAskPostEncodeJSON
        com.bigdata.rdf.sail.webapp.ExampleProtocolTest.test101
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectGetJSON
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testAskGetXML
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectGetXML
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectPostEncodeJSON
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectPostEncodeXML
        com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testAskPostEncodeXML
        com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testSelectPostXML
        com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testAskPostXML
        com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testSelectPostJSON
        com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testAskPostJSON
        com.bigdata.rdf.sail.webapp.TestAskJsonTrac704.testAskGetJSON
        com.bigdata.rdf.sail.webapp.TestAskJsonTrac704.testAskPostEncodeJSON
        
        Show
        beebs Brad Bebee added a comment - stasmalyshev The following tests failed. I haven't looked at them all, but you can run them individually such as: mvn -DtestClass=com.bigdata.rdf.sail.webapp.TestNanoSparqlServerWithProxyIndexManager -Dtest=com.bigdata.rdf.sail.webapp.ExampleProtocolTest#test101 test Based on this one, it appears that Jetty 9.4 adds the utf-8 return type (see below). It's quite possible at all of these failures are a similar cause. com.bigdata.rdf.sail.webapp.ExampleProtocolTest.test101(com.bigdata.rdf.sail.webapp.ExampleProtocolTest) Run 1: ExampleProtocolTest.test101:46 expected:<...n/sparql-results+xml[]> but was:<...n/sparql-results+xml[;charset=utf-8]> Run 2: ExampleProtocolTest.test101:46 expected:<...n/sparql-results+xml[]> but was:<...n/sparql-results+xml[;charset=utf-8]> Run 3: ExampleProtocolTest.test101:46 expected:<...n/sparql-results+xml[]> but was:<...n/sparql-results+xml[;charset=utf-8]> com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testTupleQueryDataset com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testTupleQueryIncludeInferred com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testTupleQueryBindings com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testTupleQueryBaseURI com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testExport com.bigdata.rdf.sail.remote.BigdataSailRemoteRepositoryConnectionTest.testGetStatements com.bigdata.rdf.sail.webapp.ExampleProtocolTest.test101 com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectGetJSON com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testAskGetXML com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectGetXML com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectPostEncodeJSON com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectPostEncodeXML com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testAskPostEncodeXML com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testSelectPostXML com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testAskPostXML com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testSelectPostJSON com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testAskPostJSON com.bigdata.rdf.sail.webapp.TestAskJsonTrac704.testAskGetJSON com.bigdata.rdf.sail.webapp.TestAskJsonTrac704.testAskPostEncodeJSON com.bigdata.rdf.sail.webapp.ExampleProtocolTest.test101 com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectGetJSON com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testAskGetXML com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectGetXML com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectPostEncodeJSON com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testSelectPostEncodeXML com.bigdata.rdf.sail.webapp.TestRelease123Protocol.testAskPostEncodeXML com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testSelectPostXML com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testAskPostXML com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testSelectPostJSON com.bigdata.rdf.sail.webapp.TestPostNotURLEncoded.testAskPostJSON com.bigdata.rdf.sail.webapp.TestAskJsonTrac704.testAskGetJSON com.bigdata.rdf.sail.webapp.TestAskJsonTrac704.testAskPostEncodeJSON
        Hide
        stasmalyshev stasmalyshev added a comment -

        This looks like a benign case of header format changing (and specifying charset sounds like a good idea in general). I'll see if I can just update the expected results.

        Show
        stasmalyshev stasmalyshev added a comment - This looks like a benign case of header format changing (and specifying charset sounds like a good idea in general). I'll see if I can just update the expected results.
        Hide
        stasmalyshev stasmalyshev added a comment -

        The format ones are fixed - I've pushed the patch for it - but the BigdataSailRemoteRepositoryConnectionTest seems to be deeper. Looks like something is not connecting with new Jetty in MockRemoteRepository - it returns empty answers instead of the content is is supposed to produce. I'll dig into it a bit more.

        Show
        stasmalyshev stasmalyshev added a comment - The format ones are fixed - I've pushed the patch for it - but the BigdataSailRemoteRepositoryConnectionTest seems to be deeper. Looks like something is not connecting with new Jetty in MockRemoteRepository - it returns empty answers instead of the content is is supposed to produce. I'll dig into it a bit more.
        Hide
        stasmalyshev stasmalyshev added a comment -

        OK, I figured out what was wrong with MockRemoteRepository - now all the tests above should pass with https://github.com/blazegraph/database/pull/124

        Show
        stasmalyshev stasmalyshev added a comment - OK, I figured out what was wrong with MockRemoteRepository - now all the tests above should pass with https://github.com/blazegraph/database/pull/124
        Hide
        beebs Brad Bebee added a comment -

        I just cherry-picked those changes and restarted a CI run.

        Show
        beebs Brad Bebee added a comment - I just cherry-picked those changes and restarted a CI run.
        Hide
        beebs Brad Bebee added a comment -

        Looks good.

        Show
        beebs Brad Bebee added a comment - Looks good.

          People

          • Assignee:
            beebs Brad Bebee
            Reporter:
            stasmalyshev stasmalyshev
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: