Details

      Description

      Previously, while query evaluation was subject to timeout, query compiling was not.
      Unfortunately, things like constant regexes (see BLZG-8999), which are evaluated
      in compile phase, can also take unlimited amount of time.

        Issue Links

          Activity

          Show
          beebs Brad Bebee added a comment - stasmalyshev https://github.com/blazegraph/database/pull/69
          Hide
          beebs Brad Bebee added a comment -

          thompsonbry Cherry-picked and now running in CI.

          Show
          beebs Brad Bebee added a comment - thompsonbry Cherry-picked and now running in CI.
          Hide
          beebs Brad Bebee added a comment -

          CI failed. I updated the PR with the change below and it now passes.

                      //The semantics of FutureTask are such that a timeout "Waits if necessary for at most the given time".
                       //In Blazegraph, a time out of zero means unlimited.
                       final long queryTimeout = BigdataRDFContext.getQueryTimeout(task.req, context.getConfig().queryTimeout);
                       if(queryTimeout > 0) { //If the query timeout is not unlimited, pass it to the FutureTask.
                          ft.get(queryTimeout , TimeUnit.MILLISECONDS);
                       } else {
                       	ft.get();
                       }
          
          Show
          beebs Brad Bebee added a comment - CI failed. I updated the PR with the change below and it now passes. //The semantics of FutureTask are such that a timeout "Waits if necessary for at most the given time" . //In Blazegraph, a time out of zero means unlimited. final long queryTimeout = BigdataRDFContext.getQueryTimeout(task.req, context.getConfig().queryTimeout); if (queryTimeout > 0) { //If the query timeout is not unlimited, pass it to the FutureTask. ft.get(queryTimeout , TimeUnit.MILLISECONDS); } else { ft.get(); }

            People

            • Assignee:
              beebs Brad Bebee
              Reporter:
              beebs Brad Bebee
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: