Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-556

Optimization for GRAPH uri {} and GRAPH ?foo {}

    Details

      Description

      Optimize two named graph constructions:


      - GRAPH uri {} (existence test for a non-empty graph).


      - GRAPH ?foo {} (enumerate all named graph contexts).

        Activity

        Hide
        jeremycarroll jeremycarroll added a comment -

        As of commit 7307 (and presumably earlier) the testing version GRAPH uri {} works.
        I will add a further test for the case where the graph is empty

        Show
        jeremycarroll jeremycarroll added a comment - As of commit 7307 (and presumably earlier) the testing version GRAPH uri {} works. I will add a further test for the case where the graph is empty
        Hide
        jeremycarroll jeremycarroll added a comment -

        GRAPH uri {} does not work! It always matches, when it shouldn't, if there is no graph in the dataset. Added a test to exercise this point.

        I believe it is an implementation variant as to whether or not the empty graph matches. I have tests for this case, and the tests presuppose that bigdata supports empty graphs in the dataset. If this is incorrect assumption, then the two tests will need tweaking

        Show
        jeremycarroll jeremycarroll added a comment - GRAPH uri {} does not work! It always matches, when it shouldn't, if there is no graph in the dataset. Added a test to exercise this point. I believe it is an implementation variant as to whether or not the empty graph matches. I have tests for this case, and the tests presuppose that bigdata supports empty graphs in the dataset. If this is incorrect assumption, then the two tests will need tweaking
        Hide
        michaelschmidt michaelschmidt added a comment -

        Implemented special case for pattern "GRAPH {}". The idea is to cover this via an ASK query testing whether the statement exists. Along the lines, removed unneeded collection var graphGroups and did some minor refactoring to simplify code. Test cases are included.

        See branch ticket_429, pull request issued.

        Show
        michaelschmidt michaelschmidt added a comment - Implemented special case for pattern "GRAPH {}". The idea is to cover this via an ASK query testing whether the statement exists. Along the lines, removed unneeded collection var graphGroups and did some minor refactoring to simplify code. Test cases are included. See branch ticket_429, pull request issued.
        Hide
        michaelschmidt michaelschmidt added a comment -

        Merged into master.

        Show
        michaelschmidt michaelschmidt added a comment - Merged into master.

          People

          • Assignee:
            michaelschmidt michaelschmidt
            Reporter:
            bryanthompson bryanthompson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: