Details

      Description

      Error Message

      Test did not close temp store(s): nopen=20, nclose=22, test=class com.bigdata.rdf.sail.contrib.TestRollbacksTx.testManyShortRuns, testClass=com.bigdata.rdf.sail.TestBigdataSailWithoutSids

      Stacktrace

      junit.framework.AssertionFailedError: Test did not close temp store(s): nopen=20, nclose=22, test=class com.bigdata.rdf.sail.contrib.TestRollbacksTx.testManyShortRuns, testClass=com.bigdata.rdf.sail.TestBigdataSailWithoutSids
      	at com.bigdata.journal.TestHelper.checkTempStoresClosed(TestHelper.java:145)
      	at com.bigdata.journal.TestHelper.checkJournalsClosed(TestHelper.java:112)
      	at com.bigdata.rdf.sail.AbstractBigdataSailTestCase.tearDown(AbstractBigdataSailTestCase.java:104)
      	at com.bigdata.rdf.sail.ProxyBigdataSailTestCase.tearDown(ProxyBigdataSailTestCase.java:163)
      	at com.bigdata.rdf.sail.contrib.TestRollbacks.tearDown(TestRollbacks.java:145)
      

        Activity

        beebs Brad Bebee created issue -
        Hide
        bryanthompson bryanthompson added a comment -

        Martyn, would you please take a look at this one as well. Thanks, Bryan

        Show
        bryanthompson bryanthompson added a comment - Martyn, would you please take a look at this one as well. Thanks, Bryan
        Hide
        bryanthompson bryanthompson added a comment -

        (It's probably just a failure of the test to ensure that the transaction is closed on all code paths when the test exits).

        Show
        bryanthompson bryanthompson added a comment - (It's probably just a failure of the test to ensure that the transaction is closed on all code paths when the test exits).
        Hide
        bryanthompson bryanthompson added a comment -

        I've added versions of this test with truth maintenance enabled (for triples and sids modes).

        I've modified TestSids, which runs before this test in the TestBigdataSailWithSids test suite, to improve its finally clauses handling the open connection and the open sail.

        I've also checked TestTxCreate, which runs before this test in the TestBigdataSailWithSids and the TestBigdataSailWithQuads test suites.

        There were ambiguous invocations of BigdataSailConnection#isOpen() in two derived classes. I have modified to those to test the 'open' field instead.

        Show
        bryanthompson bryanthompson added a comment - I've added versions of this test with truth maintenance enabled (for triples and sids modes). I've modified TestSids, which runs before this test in the TestBigdataSailWithSids test suite, to improve its finally clauses handling the open connection and the open sail. I've also checked TestTxCreate, which runs before this test in the TestBigdataSailWithSids and the TestBigdataSailWithQuads test suites. There were ambiguous invocations of BigdataSailConnection#isOpen() in two derived classes. I have modified to those to test the 'open' field instead.
        Hide
        bryanthompson bryanthompson added a comment -

        I've added versions of this test with truth maintenance enabled (for triples and sids modes).

        I've modified TestSids, which runs before this test in the TestBigdataSailWithSids test suite, to improve its finally clauses handling the open connection and the open sail.

        I've also checked TestTxCreate, which runs before this test in the TestBigdataSailWithSids and the TestBigdataSailWithQuads test suites.

        There were ambiguous invocations of BigdataSailConnection#isOpen() in two derived classes. I have modified to those to test the 'open' field instead.

        Show
        bryanthompson bryanthompson added a comment - I've added versions of this test with truth maintenance enabled (for triples and sids modes). I've modified TestSids, which runs before this test in the TestBigdataSailWithSids test suite, to improve its finally clauses handling the open connection and the open sail. I've also checked TestTxCreate, which runs before this test in the TestBigdataSailWithSids and the TestBigdataSailWithQuads test suites. There were ambiguous invocations of BigdataSailConnection#isOpen() in two derived classes. I have modified to those to test the 'open' field instead.
        Hide
        bryanthompson bryanthompson added a comment -

        Renamed 'open' fields on BigdataSail and BigdataSailConnection as openSail and openConn to help identify incorrect inheritance problems.

        Renamed assertOpen() methods as assertOpenConn() and assertOpenSail().

        Renamed assertWritable() as assertWritableConn()

        Modified toString() on the connection classes to show whether the connection is open.

        Made the anonymous BigdataSailConnection classes into named inner classes in an attempt to prevent future ambiguity in the inheritance patterns.

        Note: It would be far better if BigdataSailConnection were a static class since that would remove the opportunity entirely for incorrect inheritance patterns.

        Show
        bryanthompson bryanthompson added a comment - Renamed 'open' fields on BigdataSail and BigdataSailConnection as openSail and openConn to help identify incorrect inheritance problems. Renamed assertOpen() methods as assertOpenConn() and assertOpenSail(). Renamed assertWritable() as assertWritableConn() Modified toString() on the connection classes to show whether the connection is open. Made the anonymous BigdataSailConnection classes into named inner classes in an attempt to prevent future ambiguity in the inheritance patterns. Note: It would be far better if BigdataSailConnection were a static class since that would remove the opportunity entirely for incorrect inheritance patterns.
        Hide
        bryanthompson bryanthompson added a comment -

        I am seeing problems in TestBigdataSailWithoutSids:

        TestSearchQuery#test_restart() // did not close temp store.
        TestSearchQuery#testWithNamedGraphs() // did not release buffers.
        TestQuery#test_query() // did not close temp store.
        TestProvenanceQuery#test_query() // did not release buffers.
        
        Show
        bryanthompson bryanthompson added a comment - I am seeing problems in TestBigdataSailWithoutSids: TestSearchQuery#test_restart() // did not close temp store. TestSearchQuery#testWithNamedGraphs() // did not release buffers. TestQuery#test_query() // did not close temp store. TestProvenanceQuery#test_query() // did not release buffers.
        Hide
        bryanthompson bryanthompson added a comment -

        TestSearchQuery
        - the Journal was not closing the TemporaryStoreFactory for a normal close() but only in destroyResources(). I moved that code into _close(), which is now overridden by the Journal.

        TestSearchQuery#test_restart()
        - improved nested try/finally to close connections.

        Committed revision r4600.

        Show
        bryanthompson bryanthompson added a comment - TestSearchQuery - the Journal was not closing the TemporaryStoreFactory for a normal close() but only in destroyResources(). I moved that code into _close(), which is now overridden by the Journal. TestSearchQuery#test_restart() - improved nested try/finally to close connections. Committed revision r4600.
        beebs Brad Bebee made changes -
        Field Original Value New Value
        Workflow Trac Import v2 [ 12296 ] Trac Import v3 [ 13884 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v3 [ 13884 ] Trac Import v4 [ 15213 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v4 [ 15213 ] Trac Import v5 [ 16599 ]
        beebs Brad Bebee made changes -
        Labels Issue_patch_20150625
        beebs Brad Bebee made changes -
        Status Closed - Won't Fix [ 6 ] Open [ 1 ]
        beebs Brad Bebee made changes -
        Status Open [ 1 ] Accepted [ 10101 ]
        beebs Brad Bebee made changes -
        Status Accepted [ 10101 ] In Progress [ 3 ]
        beebs Brad Bebee made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        beebs Brad Bebee made changes -
        Status Resolved [ 5 ] In Review [ 10100 ]
        beebs Brad Bebee made changes -
        Resolution Fixed [ 1 ] Done [ 10000 ]
        Status In Review [ 10100 ] Done [ 10000 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v5 [ 16599 ] Trac Import v6 [ 17837 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v6 [ 17837 ] Trac Import v7 [ 19234 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v7 [ 19234 ] Trac Import v8 [ 20855 ]

          People

          • Assignee:
            bryanthompson bryanthompson
            Reporter:
            bryanthompson bryanthompson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: