Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-454

CI has side-effect of test failure in TestDoubleOpen

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Affects Version/s: QUADS_QUERY_BRANCH
    • Fix Version/s: None
    • Component/s: Journal

      Description

      com.bigdata.journal.TestDoubleOpen is having a side effect which causes some subsequent tests in TestCompactJournal to fail when they would otherwise succeed.

              // test behavior when journal is opened by two threads.
              suite.addTestSuite(TestDoubleOpen.class);
      
              // test compacting merge of a Journal.
              suite.addTestSuite(TestCompactJournal.class);
      

      Sample errors produced for those test failures are:

      Test did not close journal(s): nopen=2, nclose=1, ndestroy=1, test=class com.bigdata.journal.TestDoubleOpen.test_doubleOpen, testClass=com.bigdata.journal.TestWORMStrategy
      
      junit.framework.AssertionFailedError: Test did not close journal(s): nopen=2, nclose=1, ndestroy=1, test=class com.bigdata.journal.TestDoubleOpen.test_doubleOpen, testClass=com.bigdata.journal.TestWORMStrategy
      at com.bigdata.journal.TestHelper.checkJournalsClosed(TestHelper.java:82)
      at com.bigdata.journal.AbstractJournalTestCase.tearDown(AbstractJournalTestCase.java:88)
      at com.bigdata.journal.ProxyTestCase.tearDown(ProxyTestCase.java:151)
      

      which then leads into a "false" error in TestCompactJournal

      	Test did not release buffer(s): nacquired=18, nreleased=12, test=class com.bigdata.journal.TestCompactJournal.test_emptyJournal, testClass=com.bigdata.journal.TestWORMStrategy
      
      junit.framework.AssertionFailedError: Test did not release buffer(s): nacquired=18, nreleased=12, test=class com.bigdata.journal.TestCompactJournal.test_emptyJournal, testClass=com.bigdata.journal.TestWORMStrategy
      at com.bigdata.io.DirectBufferPoolTestHelper.checkBufferPools(DirectBufferPoolTestHelper.java:81)
      at com.bigdata.journal.TestHelper.checkJournalsClosed(TestHelper.java:113)
      at com.bigdata.journal.AbstractJournalTestCase.tearDown(AbstractJournalTestCase.java:88)
      at com.bigdata.journal.ProxyTestCase.tearDown(ProxyTestCase.java:151)
      

      The presumed mechanism for the false error is the lazy close via a finalizer of the second view onto the same backing journal file in TestDoubleOpen. That close can occur during a follow on test, causing that test to report an unbalanced journal open/close.

        Activity

        beebs Brad Bebee created issue -
        beebs Brad Bebee made changes -
        Field Original Value New Value
        Workflow Trac Import v2 [ 12290 ] Trac Import v3 [ 13878 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v3 [ 13878 ] Trac Import v4 [ 15207 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v4 [ 15207 ] Trac Import v5 [ 16593 ]
        beebs Brad Bebee made changes -
        Labels Issue_patch_20150625
        beebs Brad Bebee made changes -
        Status Closed - Won't Fix [ 6 ] Open [ 1 ]
        beebs Brad Bebee made changes -
        Status Open [ 1 ] Accepted [ 10101 ]
        beebs Brad Bebee made changes -
        Status Accepted [ 10101 ] In Progress [ 3 ]
        beebs Brad Bebee made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        beebs Brad Bebee made changes -
        Status Resolved [ 5 ] In Review [ 10100 ]
        beebs Brad Bebee made changes -
        Resolution Fixed [ 1 ] Done [ 10000 ]
        Status In Review [ 10100 ] Done [ 10000 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v5 [ 16593 ] Trac Import v6 [ 17832 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v6 [ 17832 ] Trac Import v7 [ 19229 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v7 [ 19229 ] Trac Import v8 [ 20850 ]

          People

          • Assignee:
            bryanthompson bryanthompson
            Reporter:
            bryanthompson bryanthompson
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: