Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-300

RingBuffer::contains should check for null arg

    Details

    • Type: New Feature
    • Status: Done
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Other

      Description

      RingBuffer::contains should check for null arg and throw an exception (in line with the other methods). Curretnly, the lack of a check will "waste" compute cycles looking for a null element on a queue that doesn't allow null elements.

        Activity

        Hide
        resendes resendes added a comment -

        As a side note, the comment in this method should also be changed to reflect that the search ordering is done from LRU to MRU.

        Show
        resendes resendes added a comment - As a side note, the comment in this method should also be changed to reflect that the search ordering is done from LRU to MRU.
        Hide
        resendes resendes added a comment -

        RingBuffer:remove(Object ref) has the same issue

        Show
        resendes resendes added a comment - RingBuffer:remove(Object ref) has the same issue

          People

          • Assignee:
            Unassigned
            Reporter:
            resendes resendes
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: