Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-268

shutdownNow() should cancel tasks which did not run

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Other

      Description

      ExecutorService#shutdownNow() does not cancel tasks which have not yet begun to execute. Instead a List<Runnable> is returned. Write a wrapper class based on the DelegateExecutorService (in Bryan's dev branch) to cancel those tasks so threads waiting on get() will notice that the task will never run.

        Activity

        Hide
        bryanthompson bryanthompson added a comment -

        On reflection, this does not appear to be a problem. It would be an issue if the tasks were visible outside of the context in which they are executing since they would never become done, but we run everything on the IndexManager's executor service, or on a service that is shutdown with the IndexManager's executor service, so everything winds up cancelled during a shutdown.

        Show
        bryanthompson bryanthompson added a comment - On reflection, this does not appear to be a problem. It would be an issue if the tasks were visible outside of the context in which they are executing since they would never become done, but we run everything on the IndexManager's executor service, or on a service that is shutdown with the IndexManager's executor service, so everything winds up cancelled during a shutdown.

          People

          • Assignee:
            Unassigned
            Reporter:
            bryanthompson bryanthompson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: