Details

      Description

      Query hints are partly broken and need to be more thoroughly tested. The history on this is that query hints evolved rather late and have partly replace a previous mechanism that allowed magic predicates to be made visible without the QueryHintRegistry. The code therefore handles query hints correctly in some cases, but mainly those that receive enough attention.

      The test suites for query hints are incomplete in the following ways:


      - the hints covered (not all query hints are tested);
      - the nexting scopes of the SPARQL queries to which they are applied and the scope in which they are given;
      - the execution semantics
      - specifically marking sure that the query hints are


      - transferred onto the PipelineOp and Predicate data structures;


      - that the actual execution of the relevant PipelineOp and the AccessPaths reading from those Predicates correctly reflects the intended semantics of the query hint.


      - verifying the correct annotation of AST2BOPContext.queryHints
      - for some query hints (such as the ChunkSizeHint), the localName of the as given query hint is not the same value that is actually recorded on AST2BOpContext.queryHints.

      In particular, problems have been identified with:


      - ChunkSizeHint: failure to set the correct name in the global scope on AST2BOpContext.queryHints.
      - Query hints for BufferAnnotation were not being set on the Predicate and thus were not being respected by the AccessPath, just by the PipelineOp.

        Activity

        beebs Brad Bebee created issue -
        beebs Brad Bebee made changes -
        Field Original Value New Value
        Workflow Trac Import v2 [ 11998 ] Trac Import v3 [ 13626 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v3 [ 13626 ] Trac Import v4 [ 14955 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v4 [ 14955 ] Trac Import v5 [ 16343 ]
        beebs Brad Bebee made changes -
        Labels Issue_patch_20150625
        beebs Brad Bebee made changes -
        Status Closed - Won't Fix [ 6 ] Open [ 1 ]
        beebs Brad Bebee made changes -
        Status Open [ 1 ] Accepted [ 10101 ]
        beebs Brad Bebee made changes -
        Status Accepted [ 10101 ] In Progress [ 3 ]
        beebs Brad Bebee made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        beebs Brad Bebee made changes -
        Status Resolved [ 5 ] In Review [ 10100 ]
        beebs Brad Bebee made changes -
        Resolution Fixed [ 1 ] Done [ 10000 ]
        Status In Review [ 10100 ] Done [ 10000 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v5 [ 16343 ] Trac Import v6 [ 17604 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v6 [ 17604 ] Trac Import v7 [ 18999 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v7 [ 18999 ] Trac Import v8 [ 20618 ]

          People

          • Assignee:
            bryanthompson bryanthompson
            Reporter:
            bryanthompson bryanthompson
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: