Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-1446

Provide detailed statistics on execution performance inside of SPARQL UPDATE requests.

    Details

    • Type: Improvement
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: BLAZEGRAPH_RELEASE_1_5_3
    • Component/s: None
    • Labels:
      None

      Description

      If you enable the monitor option for SPARQL UPDATE it already provides information about each operation in a SPARQL update request. This ticket is to add additional information for DELETE/INSERT + WHERE operations that break down the time for the WHERE clause and the time for the DELETE and INSERT clauses.

      1. AST2BOpUpdate.java
        79 kB
        bryanthompson
      2. BigdataRDFContext.java
        101 kB
        bryanthompson
      3. SPARQLUpdateEvent.java
        6 kB
        bryanthompson

        Activity

        Hide
        bryanthompson bryanthompson added a comment -

        Modified the following files:

        • BigdataRDFContext
        • SPARQLUpdateEvent
        • AST2BOpUpdate

        Using [x] Monitor (or &monitor=true) now reports the following metadata for DELETE/INSERT + WHERE:

        totalElapsed=35ms, elapsed=24ms, whereClause=0ms, deleteClause=0ms, insertClause=0ms
        
        

        I will attach my versions of these files so the patch can be tested on wikidata.

        Show
        bryanthompson bryanthompson added a comment - Modified the following files: BigdataRDFContext SPARQLUpdateEvent AST2BOpUpdate Using [x] Monitor (or &monitor=true) now reports the following metadata for DELETE/INSERT + WHERE: totalElapsed=35ms, elapsed=24ms, whereClause=0ms, deleteClause=0ms, insertClause=0ms I will attach my versions of these files so the patch can be tested on wikidata.
        Hide
        bryanthompson bryanthompson added a comment -

        My locally modified versions are attached. Note that these changes are against the post-maven refactor version of master. There may be other deltas over the 1.5.2 release. It should be quite obvious which changes are related to this ticket.

        Show
        bryanthompson bryanthompson added a comment - My locally modified versions are attached. Note that these changes are against the post-maven refactor version of master. There may be other deltas over the 1.5.2 release. It should be quite obvious which changes are related to this ticket.
        Hide
        bryanthompson bryanthompson added a comment -

        Could not run the test suite (post-maven eclipse issue).

        Created PR https://github.com/SYSTAP/bigdata/pull/144

        Merge to master if clean.

        Show
        bryanthompson bryanthompson added a comment - Could not run the test suite (post-maven eclipse issue). Created PR https://github.com/SYSTAP/bigdata/pull/144 Merge to master if clean.
        Hide
        stasmalyshev stasmalyshev added a comment -

        The attached version misses one import in AST2BOpUpdate.java:

        //import org.openrdf.query.impl.MutableTupleQueryResult;

        As you see, this is commented out. In that form, it does not build. If I uncomment it, it builds fine.

        Show
        stasmalyshev stasmalyshev added a comment - The attached version misses one import in AST2BOpUpdate.java: //import org.openrdf.query.impl.MutableTupleQueryResult; As you see, this is commented out. In that form, it does not build. If I uncomment it, it builds fine.
        Hide
        stasmalyshev stasmalyshev added a comment - - edited

        The patch works now but I always get zeroes:

        whereClause=0ms, deleteClause=0ms, insertClause=0ms

        Also, when I check "monitor" in the GUI Update query, I just get this:

        COMMIT: totalElapsed=0ms, commitTime=0, mutationCount=0

        with no additional details and looks like it doesn't even execute the query (mutation count is always 0).

        Show
        stasmalyshev stasmalyshev added a comment - - edited The patch works now but I always get zeroes: whereClause=0ms, deleteClause=0ms, insertClause=0ms Also, when I check "monitor" in the GUI Update query, I just get this: COMMIT: totalElapsed=0ms, commitTime=0, mutationCount=0 with no additional details and looks like it doesn't even execute the query (mutation count is always 0).
        Hide
        beebs Brad Bebee added a comment -

        I've merged the BLZG-1446 files in BLAZEGRAPH_RELEASE_1_5_2_MAINTENANCE. Once CI is clean, we can push.

        https://ci.blazegraph.com/job/BLAZEGRAPH_RELEASE_1_5_2_MAINTENANCE/

        Show
        beebs Brad Bebee added a comment - I've merged the BLZG-1446 files in BLAZEGRAPH_RELEASE_1_5_2_MAINTENANCE. Once CI is clean, we can push. https://ci.blazegraph.com/job/BLAZEGRAPH_RELEASE_1_5_2_MAINTENANCE/

          People

          • Assignee:
            bryanthompson bryanthompson
            Reporter:
            bryanthompson bryanthompson
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: