Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-1438

avoid code duplication imposed by HashIndexOp and its subclasses

    Details

      Description

      The current implementation of HashIndexOp and its two subclasses (HTreeHashIndexOp and JVMHashIndexOp) imposes a lot of code duplication. Moreover, reusing HashIndexOp as a basis for implementing GpuJoinGroupOp would introduce more code duplication.

        Activity

        Hide
        bryanthompson bryanthompson added a comment -

        Changes have been merged to master.

        Show
        bryanthompson bryanthompson added a comment - Changes have been merged to master.
        Hide
        beebs Brad Bebee added a comment -

        thompsonbry Propose this one for 1.6.0. Please update if you agree.

        Show
        beebs Brad Bebee added a comment - thompsonbry Propose this one for 1.6.0. Please update if you agree.
        Hide
        Olaf Hartig Olaf Hartig added a comment -

        Note that the changes for his ticket are already in master. They were brought in by PR #137. See: https://github.com/SYSTAP/bigdata/pull/137

        Show
        Olaf Hartig Olaf Hartig added a comment - Note that the changes for his ticket are already in master. They were brought in by PR #137. See: https://github.com/SYSTAP/bigdata/pull/137
        Hide
        bryanthompson bryanthompson added a comment -

        We will be releasing 1.5.3 from the pre-maven refactor. We are cherry picking some changes out of master (post-maven) into the 1.5.2 maintenance branch and then doing the release from the 1.5.2 maintenance branch. This gives us some more time to get the various maven artifact projects into shape for a maven-based release. That maven-based released will be 1.60.

        Show
        bryanthompson bryanthompson added a comment - We will be releasing 1.5.3 from the pre-maven refactor. We are cherry picking some changes out of master (post-maven) into the 1.5.2 maintenance branch and then doing the release from the 1.5.2 maintenance branch. This gives us some more time to get the various maven artifact projects into shape for a maven-based release. That maven-based released will be 1.60.
        Hide
        Olaf Hartig Olaf Hartig added a comment -

        Sounds pretty reasonable. Thanks for the info.

        Show
        Olaf Hartig Olaf Hartig added a comment - Sounds pretty reasonable. Thanks for the info.
        Hide
        beebs Brad Bebee added a comment -

        Moving into 1.5.3 due to merge of BLZG-1493.

        Show
        beebs Brad Bebee added a comment - Moving into 1.5.3 due to merge of BLZG-1493 .
        Hide
        bryanthompson bryanthompson added a comment -

        This is not the only way to solve this problem. The code change to the hash index op, solution set hash join, etc. was very minor (basically, javadoc only). it could simply be applied to the 1.5.3 RC branch. That was how I expected my change for the resolution of the IHashIndexUtility objects to get propagated. If you look at my delta, the substantive change was in BOpContext, not in these hash join classes.

        Show
        bryanthompson bryanthompson added a comment - This is not the only way to solve this problem. The code change to the hash index op, solution set hash join, etc. was very minor (basically, javadoc only). it could simply be applied to the 1.5.3 RC branch. That was how I expected my change for the resolution of the IHashIndexUtility objects to get propagated. If you look at my delta, the substantive change was in BOpContext, not in these hash join classes.

          People

          • Assignee:
            beebs Brad Bebee
            Reporter:
            Olaf Hartig Olaf Hartig
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: