Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-129

Test suite for writeCheckpoint() and recycling for BTree/HTree

    Details

    • Type: Task
    • Status: Done
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: B+Tree

      Description

      Write a test suite for the B+Tree and HTree classes which verifies that writeCheckpoint() correctly determines conditions under which a checkpoint record should and should not be written and further verifies that checkpoint, root node/leaf (or root directory page), index metadata, and bloom filter records are recycled IFF they are dirty and verifies that the checkpoint record entries are updated correctly for all cases.

        Activity

        beebs Brad Bebee created issue -
        Hide
        bryanthompson bryanthompson added a comment -

        Enables IndexMetadata recycling (this code path is nearly never used as only scale-out tends to update the IndexMetadata object after the index has been created).

        Adds TestBTreeRecycle with a test suite focused on the behavior of writeCheckpoint2(). This covers Checkpoint, root addr, IndexMetadata, and bloom filter recycling. There are two versions of the test. One with and one without a bloom filter. The test suite does not examine how nodes and leaves are recycled in a large index, just an index having a single root leaf.

        @see http://sourceforge.net/apps/trac/bigdata/ticket/473 (PhysicalAddressResolutionException after reopen using RWStore and recycler)

        @see http://sourceforge.net/apps/trac/bigdata/ticket/476 (Test suite for writeCheckpoint() and recycling for BTree/HTree)

        Committed revision r5977.

        I have not written anything for the HTree. This ticket is assigned to Martyn for that purpose.

        Show
        bryanthompson bryanthompson added a comment - Enables IndexMetadata recycling (this code path is nearly never used as only scale-out tends to update the IndexMetadata object after the index has been created). Adds TestBTreeRecycle with a test suite focused on the behavior of writeCheckpoint2(). This covers Checkpoint, root addr, IndexMetadata, and bloom filter recycling. There are two versions of the test. One with and one without a bloom filter. The test suite does not examine how nodes and leaves are recycled in a large index, just an index having a single root leaf. @see http://sourceforge.net/apps/trac/bigdata/ticket/473 (PhysicalAddressResolutionException after reopen using RWStore and recycler) @see http://sourceforge.net/apps/trac/bigdata/ticket/476 (Test suite for writeCheckpoint() and recycling for BTree/HTree) Committed revision r5977. I have not written anything for the HTree. This ticket is assigned to Martyn for that purpose.
        Hide
        martyncutcher martyncutcher added a comment -

        Committed revision r6035.

        Unit tests added for HTree. Now correctly recycles associated checkpoint data.

        Show
        martyncutcher martyncutcher added a comment - Committed revision r6035. Unit tests added for HTree. Now correctly recycles associated checkpoint data.
        beebs Brad Bebee made changes -
        Field Original Value New Value
        Workflow Trac Import v2 [ 11965 ] Trac Import v3 [ 13595 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v3 [ 13595 ] Trac Import v4 [ 14924 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v4 [ 14924 ] Trac Import v5 [ 16312 ]
        beebs Brad Bebee made changes -
        Labels Issue_patch_20150625
        beebs Brad Bebee made changes -
        Status Closed - Won't Fix [ 6 ] Open [ 1 ]
        beebs Brad Bebee made changes -
        Status Open [ 1 ] Accepted [ 10101 ]
        beebs Brad Bebee made changes -
        Status Accepted [ 10101 ] In Progress [ 3 ]
        beebs Brad Bebee made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        beebs Brad Bebee made changes -
        Status Resolved [ 5 ] In Review [ 10100 ]
        beebs Brad Bebee made changes -
        Resolution Fixed [ 1 ] Done [ 10000 ]
        Status In Review [ 10100 ] Done [ 10000 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v5 [ 16312 ] Trac Import v6 [ 17574 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v6 [ 17574 ] Trac Import v7 [ 18969 ]
        beebs Brad Bebee made changes -
        Workflow Trac Import v7 [ 18969 ] Trac Import v8 [ 20588 ]

          People

          • Assignee:
            martyncutcher martyncutcher
            Reporter:
            bryanthompson bryanthompson
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: