Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-1255

AbstractJournal has RWStrategy tests where it should test on IAllocationManager

    XMLWordPrintable

    Details

      Description

      There are some methods in AbstractJournal that need to be reviewed such as

          @Override
          public void delete(final long addr, final IAllocationContext context) {
      
              assertCanWrite();
      
              if(_bufferStrategy instanceof IRWStrategy) {
              
                  ((IRWStrategy) _bufferStrategy).delete(addr, context);
                  
              } else {
                  
                  _bufferStrategy.delete(addr);
                  
              }
      
          }
          
          @Override
          public void detachContext(final IAllocationContext context) {
              
              assertCanWrite();
      
              if(_bufferStrategy instanceof IRWStrategy) {
      
                  ((IRWStrategy) _bufferStrategy).detachContext(context);
                  
              }
          	
          }
      

      In fact, it is not only the RWStrategy and RWStore that support this protocol. The MemStrategy also supports the protocol and it looks like these methods should be testing on the IAllocationManager.

      The impact of this ticket is that the MemStrategy would not correctly support the isolatable journal protocol used by the AbstractTask.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              martyncutcher martyncutcher
              Reporter:
              bryanthompson bryanthompson
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: