Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-1211

Inline URIs should work more like inline values

    Details

    • Type: New Feature
    • Status: Done
    • Priority: Highest
    • Resolution: Fixed
    • Affects Version/s: BLAZEGRAPH_RELEASE_1_5_1
    • Fix Version/s: BLAZEGRAPH_RELEASE_1_5_2
    • Component/s: Other
    • Labels:
      None

      Description

      With inline values you get to modify the value on the way into and out of the index using the createIV and asValue methods on IExtension. With inline uris you only get to modify the value on the way into the index using InlineURIHandler's createInlineIV.

      It'd be convenient to either allow InlineURIHandler some way to unpack the iv into some other iv on the way out or to allow an AbstractInlineIV for URIExtensions's delegateIV so you could plug a LiteralExtensionIV there.

      I'm not familiar with the on disk layout so I'm not sure which would be simpler.

      For reference we have uris that can be packed into a signed integer, ones that need a signed integer plus a uuid. But they need to be unpacked into a canonical form for display on the workbench or returning over the api.

        Activity

        Hide
        bryanthompson bryanthompson added a comment -

        The patch has been merged to both SF git and github git.

        Show
        bryanthompson bryanthompson added a comment - The patch has been merged to both SF git and github git.
        Hide
        bryanthompson bryanthompson added a comment -

        We have a patch for this per the developers list.

        Nik wrote: I filed 1179 a couple of days ago and got together a patch this morning then read http://wiki.blazegraph.com/wiki/index.php/Contributors and saw that I should email here about it. So here goes:

        I want inline URIs to have the same power that inline values do. Right now inline values can be modified on the way into and out of the index. Inline URIs can only be modified on the way into the index. That leaves you pretty limited in what you can represent with them. Its OK if you can design the URI scheme around the limitation but we can't.

        I've put my patch as a gist and I've created a "merge request" for it. It gives the InlineURIHandler that built the inline URI a crack at building the localName from the inlined value. The cost is an extra HashMap lookup whenever the uri is un-inlined and the default behavior is unchanged. It doesn't change the on disk representation either.

        ----

        I have provided feedback on that patch. Once the feedback is addressed, we will be pulling in the patch and resolving this ticket.

        Show
        bryanthompson bryanthompson added a comment - We have a patch for this per the developers list. Nik wrote: I filed 1179 a couple of days ago and got together a patch this morning then read http://wiki.blazegraph.com/wiki/index.php/Contributors and saw that I should email here about it. So here goes: I want inline URIs to have the same power that inline values do. Right now inline values can be modified on the way into and out of the index. Inline URIs can only be modified on the way into the index. That leaves you pretty limited in what you can represent with them. Its OK if you can design the URI scheme around the limitation but we can't. I've put my patch as a gist and I've created a "merge request" for it. It gives the InlineURIHandler that built the inline URI a crack at building the localName from the inlined value. The cost is an extra HashMap lookup whenever the uri is un-inlined and the default behavior is unchanged. It doesn't change the on disk representation either. ---- I have provided feedback on that patch. Once the feedback is addressed, we will be pulling in the patch and resolving this ticket.
        Hide
        bryanthompson bryanthompson added a comment -

        Adding Mike to Cc.

        Show
        bryanthompson bryanthompson added a comment - Adding Mike to Cc.

          People

          • Assignee:
            Unassigned
            Reporter:
            nikolaseverett nikolaseverett
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: