Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-1176

SPARQL Parsers should not be db mode aware

    Details

    • Type: New Feature
    • Status: Done
    • Priority: Highest
    • Resolution: Done
    • Affects Version/s: BIGDATA_RELEASE_1_5_0
    • Fix Version/s: BLAZEGRAPH_2_0_0
    • Component/s: Other
    • Labels:
      None

      Description

      The fix in BLZG-1151 made the parser DB aware in the sense that it throws exceptions for, e.g., GRAPH keyword queries when parsing a query with underlying DB in triples mode.

      In general, it seems that making the parser db-mode aware is problematic (this problem popped up during benchmarking, e.g., in the NanoSparqlClient). It is already a problem that it requires the AbstractTripleStore reference. It should be able to run stateless. We could have an AST traversal that marks the top-level as using quads or other constructs that might not be legal in all db modes (such as RDR syntax). We could then flag illegal queries after the parse. We would also need to do RDF Value => IV resolution after the parse. This would make it much easier to support the syntax extensions on the client side.

        Issue Links

          Activity

          Hide
          bryanthompson bryanthompson added a comment - - edited

          PR: https://github.com/SYSTAP/bigdata/pull/168

          Code review on PR is good.

          Have merged master into branch.

          bradbebee Merge to branch to master and close ticket with clean CI.

          Show
          bryanthompson bryanthompson added a comment - - edited PR: https://github.com/SYSTAP/bigdata/pull/168 Code review on PR is good. Have merged master into branch. bradbebee Merge to branch to master and close ticket with clean CI.
          Hide
          beebs Brad Bebee added a comment -

          PR https://github.com/SYSTAP/bigdata/pull/168 merged down.
          thompsonbry Should we promote the uncompleted sub-tasks and close this ticket?

          Show
          beebs Brad Bebee added a comment - PR https://github.com/SYSTAP/bigdata/pull/168 merged down. thompsonbry Should we promote the uncompleted sub-tasks and close this ticket?
          Hide
          bryanthompson bryanthompson added a comment -

          Sure

          Show
          bryanthompson bryanthompson added a comment - Sure
          Show
          bryanthompson bryanthompson added a comment - igorkim , please address the comments at https://github.com/SYSTAP/bigdata/commit/e2b0d348741567339ca104597b8be2d1ad8bf761#commitcomment-14904688 Thanks, Bryan
          Hide
          bryanthompson bryanthompson added a comment -

          PR: https://github.com/SYSTAP/bigdata/pull/241

          bradbebee Merge to master when clean.

          Show
          bryanthompson bryanthompson added a comment - PR: https://github.com/SYSTAP/bigdata/pull/241 bradbebee Merge to master when clean.

            People

            • Assignee:
              igorkim igorkim
              Reporter:
              michaelschmidt michaelschmidt
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: