Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-1174

GlobalRowStoreHelper can hold hard reference to GSR index (GROUP COMMIT)

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Affects Version/s: BIGDATA_RELEASE_1_5_0
    • Fix Version/s: None
    • Component/s: Journal

      Description

      As documented in BLZG-1167 (blue prints test suite setup), the GRS index can be inappropriately cached along the code path leading through the DefaultResourceLocator.

      The underlying issue appears to be the cached of the GRS btree reference on the GlobalRowStoreHelper object tightly held by the Journal is not being updated when the CreateKBTask creates a GSR within the scope of an IsolatedActionJournal.

      A similar issue is documented in the constructor of the IsolatedActionJournal.

      We probably need to refactor the cache mechanisms for the GSR to support isolation by AbstractTask?.

        Activity

        Hide
        bryanthompson bryanthompson added a comment -

        I have removed the hard reference to the GSR index in the GlobalRowStore helper class. I have checked the various test suites (NSS, AST, HA3) locally and they are fine. I have reviewed the calls to obtain the unisolated view of the GSR and they appear to be Ok.

        Note: This ticket might impact update throughput. However, it should not impact query performance by application using the read-only connection (all applications written to the NSS will use a read-only connection automatically for query).

        Commit 3fddacad9d753d23178895d6c8e9e3b0f41f4923

        Show
        bryanthompson bryanthompson added a comment - I have removed the hard reference to the GSR index in the GlobalRowStore helper class. I have checked the various test suites (NSS, AST, HA3) locally and they are fine. I have reviewed the calls to obtain the unisolated view of the GSR and they appear to be Ok. Note: This ticket might impact update throughput. However, it should not impact query performance by application using the read-only connection (all applications written to the NSS will use a read-only connection automatically for query). Commit 3fddacad9d753d23178895d6c8e9e3b0f41f4923
        Hide
        bryanthompson bryanthompson added a comment -

        Note: Committed to CI for validation. I will reopen if any issues appear in CI.

        Show
        bryanthompson bryanthompson added a comment - Note: Committed to CI for validation. I will reopen if any issues appear in CI.

          People

          • Assignee:
            bryanthompson bryanthompson
            Reporter:
            bryanthompson bryanthompson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: