Uploaded image for project: 'Blazegraph (by SYSTAP)'
  1. Blazegraph (by SYSTAP)
  2. BLZG-1071

Memory leaks in NSS test suite

    XMLWordPrintable

    Details

      Description

      There are some egregious resource leaks from two of the NSS test suites that you developed. I just tried to close those leaks, but the test structure is a bit complex and my changes are not working. I suspect that setUp() and tearDown() might not be called in a manner that consistent with my expectations.

      The basic problem is that ALL instance variables in a unit test MUST be set to null in tearDown. If they are not set to null, then the will live until the test suite completes. Since we have 18000 tests, that turns into a big problem in CI. Some of the potentially leaked objects are piggish, including HttpClient objects and even Servlet objects.

      The culprits are:
      - AbstractProtocolTest
      - AbstractNamedGraphUpdateTest

      These are used from the following concrete test suites:
      - ExampleProtocolTest
      - TestAskJsonTrac704
      - TestPostNotURLEncoded
      - TestRelease123Protocol
      - TestService794

      I have attached the versions where I tried to fix this.

      I would appreciate it if you could take a look at this ASAP. Otherwise I will need to remove these tests from CI until this is resolved. Right now it is blocking me from getting a clean NSS test suite run.

        Attachments

        1. after.jpg
          after.jpg
          436 kB
        2. before.jpg
          before.jpg
          478 kB

          Activity

            People

            Assignee:
            jeremycarroll jeremycarroll
            Reporter:
            bryanthompson bryanthompson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: